Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmpv2: fix content of PkiBody::PollReq #1734

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

tomsik68
Copy link
Contributor

Hey all, my PR is related to the cmpv2 crate.

I noticed that PkiBody::PollReq and PkiBody::PollRep have the same variant content:

enum PkiBody<'a> {
    PollReq(PollRepContent<'a>),
    PollRep(PollRepContent<'a>),
}

In RFC4210 section 5.1.2, they are declared as follows:

/// PKIBody ::= CHOICE {       -- message-specific body elements
///     ...other variants omitted for brevity...
///     pollReq  [25] PollReqContent,         --Polling request
///     pollRep  [26] PollRepContent          --Polling response
/// }

I believe this discrepancy was unintended and my PR fixes it. Please let me know if you have any feedback.

Thank you!

@carl-wallace
Copy link
Contributor

That looks right to me. Thanks.

@tarcieri tarcieri merged commit 4f2771d into RustCrypto:master Mar 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants