der: error position tracking improvements #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jun 22, 2025
tarcieri
force-pushed
the
der/error-position-tracking-improvements
branch
from
968450d to
ed213b0
Compare
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Jun 22, 2025
Companion PR to RustCrypto/formats#1889
- Changes all `Tag::*_error` methods to return `ErrorKind` rather than `Error`, and changes call sites where these methods were used with a `Reader` in scope to call `reader.error()` to ensure error position is propagated appropriately. - Locates sites of `ErrorKind::*.into()` where a `Reader` is in scope and changes them to use `reader.error()`
tarcieri
force-pushed
the
der/error-position-tracking-improvements
branch
from
ed213b0 to
c506fdc
Compare
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jun 22, 2025
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Jun 22, 2025
Companion PR to RustCrypto/formats#1889
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Jun 22, 2025
Companion PR to RustCrypto/formats#1889
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Jun 22, 2025
Companion PR to RustCrypto/formats#1889
Contributor
|
Looks like you're preparing to remove |
Member
Author
|
@dishmaker it’s still used in several places where a |
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
Companion PR to RustCrypto/formats#1889
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag::*_errormethods to returnErrorKindrather thanError, and changes call sites where these methods were used with aReaderin scope to callreader.error()to ensure error position is propagated appropriately.ErrorKind::*.into()where aReaderis in scope and changes them to usereader.error()NOTE: draft because it needs changes toelliptic-curvecc @dishmaker