Derive Default for enums
#2057
Merged
Derive Default for enums
#2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
reviewed
Oct 7, 2025
| #[repr(u16)] | ||
| #[derive(Default)] | ||
| pub enum ExtensionType { | ||
| #[default] |
Member
There was a problem hiding this comment.
That seems like a bad idea to default on Reserved. Not that I believe there is another more appropriate one. I think this one should be left alone
baloo
reviewed
Oct 7, 2025
Member
baloo
left a comment
baloo
left a comment
There was a problem hiding this comment.
Not every enum should have a default. I think the clippy is still in nightly and should not be given too much weight.
| #[derive(Default)] | ||
| pub enum Version { | ||
| /// Version 1 (default) | ||
| #[default] |
Member
There was a problem hiding this comment.
This one should definitely not be v1. It should be v3 if anything.
Contributor
Author
|
But these enums had |
Member
|
Ha you mean I also need to read the left side of the diff too?! Sorry I didn't have a coffee just yet. Yeah, this is a straight replacement which doesn't change the behavior. I'm still convinced we should at least change the Version one to default to V3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly
cargo clippy --all --all-features --tests --fixSimilar to RustCrypto/traits#2035