pem-rfc7468: buffered Base64 decoder #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
pem-rfc7468/stateful-decoder
branch
from
60f1376 to
992a58f
Compare
Modifies `pem_rfc7468::Decoder` to be a wrapper around the buffered `base64ct::Decoder` type. This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications. Additionally impls `std::io::Read` for `pem_rfc7468::Decoder`, delegating to the `std::io::Read` implementation added to `base64ct::Decoder` in #404.
tarcieri
force-pushed
the
pem-rfc7468/stateful-decoder
branch
from
992a58f to
9debe24
Compare
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Now that `pem-rfc7468` supports a buffered Base64 decoder (#406), it's possible to use it for parsing PEM-formatted OpenSSH private keys. This commit switches to using `pem-rfc7468` for PEM parsing.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Now that `pem-rfc7468` supports a buffered Base64 decoder (#406), it's possible to use it for parsing PEM-formatted OpenSSH private keys. This commit switches to using `pem-rfc7468` for PEM parsing.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Now that `pem-rfc7468` supports a buffered Base64 decoder (#406), it's possible to use it for parsing PEM-formatted OpenSSH private keys. This commit switches to using `pem-rfc7468` for PEM parsing.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Now that `pem-rfc7468` supports a buffered Base64 decoder (#406), it's possible to use it for parsing PEM-formatted OpenSSH private keys. This commit switches to using `pem-rfc7468` for PEM parsing.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Now that `pem-rfc7468` supports a buffered Base64 decoder (#406), it's possible to use it for parsing PEM-formatted OpenSSH private keys. This commit switches to using `pem-rfc7468` for PEM parsing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
pem_rfc7468::Decoderto be a wrapper around the bufferedbase64ct::Decodertype.This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications.
Additionally impls
std::io::Readforpem_rfc7468::Decoder, delegating to thestd::io::Readimplementation added tobase64ct::Decoderin #404.