der: use &mut dyn Writer as output for Encode::encode
#611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements encoding in terms of the `Writer` trait. To allow `Encode` to continue to function as a trait object, the `Writer` must also be a trait object. This approach should enable 1-pass PEM encoding as well as computing key fingerprints without an output buffer. It might come at a cost to performance due to the increased use of trait objects. It might be possible to retain monomorphization using `Encode<W: Writer>` but at a cost to ergonomics. However, that might be worth exploring depending on the performance.
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
tarcieri
added a commit
that referenced
this pull request
May 4, 2022
Implements decoding generically in terms of the `Reader` trait, similar to what #611 did for encoding. This approach can enable 1-pass on-the-fly PEM decoding for `DecodeOwned` types (although that will require some additional work beyond what's in this PR).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements encoding in terms of the
Writertrait.To allow
Encodeto continue to function as a trait object, theWritermust also be a trait object.This approach should enable 1-pass PEM encoding as well as computing key fingerprints without an output buffer. It might come at a cost to performance due to the increased use of trait objects.
It might be possible to retain monomorphization using
Encode<W: Writer>but at a cost to ergonomics. However, that might be worth exploring depending on the performance.