x509-cert: make Certificate an owned type #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/owned-api/certificate
branch
from
ba1164d to
c1c0d47
Compare
tarcieri
reviewed
Dec 18, 2022
tarcieri
reviewed
Dec 18, 2022
baloo
force-pushed
the
baloo/owned-api/certificate
branch
5 times, most recently
from
a215178 to
1188fcf
Compare
|
@baloo can you rebase? |
baloo
force-pushed
the
baloo/owned-api/certificate
branch
from
1188fcf to
f41a358
Compare
|
@tarcieri done |
baloo
force-pushed
the
baloo/owned-api/certificate
branch
from
81c741d to
2109a1b
Compare
|
Thank you! |
npmccallum
added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum
added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum
added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum
added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum
added a commit
to npmccallum/formats
that referenced
this pull request
Jan 9, 2023
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
pushed a commit
that referenced
this pull request
Jan 10, 2023
#806 The above PR made most types in this crate owned. However, some types were missed. For consistency, complete the migration. Removed alloc feature: this crate unconditionally requires alloc. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
This was referenced Mar 19, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #803 let's make
Certificatean owned type. We'll revisit that in a follow up PR to accept atrait Profileas parameter allowing it to be either a reference or an owned type.