Update workspace feature resolver version to 2 #375
Conversation
Version 1 of feature resolver always causes features unification of build and dev dependencies, which is unwanted in some circumstances. For example, the `dev` feature of the `digest` always depends on `alloc` which requires to define a global allocator in static libs even though that is never used by library code.
|
UPD: Ah, I forgot we haven't migrated crates in this repository yet. |
|
Seems like the clippy job is failing because the toolchain used is an old one which does not yet support the new resolver on master. Is this (or migrating to the 2021 edition) something you would be interested in given a MSRV bump is likely needed? |
|
You can bump clippy to whatever version is needed (and really we should probably keep it close to stable to maximize the lints it performs) |
|
I've bumped clippy to 1.60 to get the latest lints. This uncovered a bunch of warnings which I have currently fixed at the best of my judgement without deep knowledge of the codebase, maybe those should be better handled in a different PR. |
zeegomo
force-pushed
the
change-resolver
branch
from
7a310c3 to
f756cb8
Compare
blake2/src/simd.rs
Outdated
| @@ -15,7 +15,7 @@ pub use self::simdty::{u32x4, u64x4}; | |||
| pub trait Vector4<T>: Copy { | |||
| fn gather(src: &[T], i0: usize, i1: usize, i2: usize, i3: usize) -> Self; | |||
|
|
|||
| fn from_le(self) -> Self; | |||
| fn from_le(vec: Self) -> Self; | |||
There was a problem hiding this comment.
Not sure why this was changed, but it's breaking the build:
https://github.com/RustCrypto/hashes/runs/5969024622?check_suite_focus=true#step:3:352
There was a problem hiding this comment.
Clippy complained about a from_* method taking self as a parameter, so I changed it to be an associated function but forgot to update it everywhere
There was a problem hiding this comment.
I think you can just disable the warning for now. FWIW we plan on switching to a different implementation eventually: #228
zeegomo
force-pushed
the
change-resolver
branch
from
f756cb8 to
37a62e7
Compare
|
Thanks!
We have it enabled in certain repos, but if you see others that don't have it on, feel free to add it. |
Version 1 of feature resolver always causes features unification of
build and dev dependencies, which is unwanted in some circumstances.
For example, the
devfeature of thedigestcrate always depends onallocwhich requires to define a global allocator in static libseven though that is never used by library code.
This might be useful in other repos as well