Remove McfHasher impls for pbkdf2 and scrypt crates
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Modular Crypt Format is a legacy format, and the implementations provided in the `pbkdf2` and `scrypt` crates implement a bespoke RustCrypto-specific format. Since that format has been introduced, support has been added to both crates for the newer PHC String Format: https://github.com/P-H-C/phc-string-format/blob/master/phc-sf-spec.md See the "Usage" rustdoc for the respective crates for information on how to use the PHC string format. Previous releases of these respective crates support converting from the MCF hash format to the PHC format using `McfHasher::upgrade_mcf_hash`: https://docs.rs/password-hash/0.3.0/password_hash/trait.McfHasher.html#tymethod.upgrade_mcf_hash Before upgrading these crates to the new release which removes MCF hash support, please use the older releases to upgrade all of your password hashes in MCF format to the new PHC format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Modular Crypt Format (MCF) is a legacy format, and the implementations provided in the
pbkdf2andscryptcrates implement a bespoke RustCrypto-specific format.Since that format has been introduced, support has been added to both crates for the newer PHC String Format:
https://github.com/P-H-C/phc-string-format/blob/master/phc-sf-spec.md
See the "Usage" rustdoc for the respective crates for information on how to use the PHC string format.
Previous releases of these respective crates support converting from the MCF hash format to the PHC format using
McfHasher::upgrade_mcf_hash:https://docs.rs/password-hash/0.3.0/password_hash/trait.McfHasher.html#tymethod.upgrade_mcf_hash
Before upgrading these crates to the new release which removes MCF hash support, please use the older releases to upgrade all of your password hashes in MCF format to the new PHC format.