Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: use verifying_key name consistently #273

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Apr 2, 2021

Previously this key type was named VerifyKey and was changed to VerifyingKey for more consistency with SigningKey.

However, some usages of verify_key were not updated. This commit updates those names to be consistent with the type name.

Previously this key type was named `VerifyKey` and was changed to
`VerifyingKey` for more consistency with `SigningKey`.

However, some usages of `verify_key` were not updated. This commit
updates those names to be consistent with the type name.
@codecov-io
Copy link

Codecov Report

Merging #273 (d1c5e79) into master (d718345) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files           8        8           
  Lines         300      300           
=======================================
  Hits          164      164           
  Misses        136      136           
Impacted Files Coverage Δ
ecdsa/src/dev.rs 80.95% <ø> (ø)
ecdsa/src/hazmat.rs 0.00% <ø> (ø)
ecdsa/src/sign.rs 0.00% <0.00%> (ø)
ecdsa/src/verify.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d718345...d1c5e79. Read the comment docs.

@tarcieri tarcieri merged commit a5418a5 into master Apr 2, 2021
@tarcieri tarcieri deleted the ecdsa/verifying-key-naming-fixes branch April 2, 2021 18:47
@tarcieri tarcieri mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants