Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: replace CheckSignatureBytes with Order #281

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

tarcieri
Copy link
Member

Uses a generic implementation for checking that the scalars in a signature are in range which doesn't require a curve arithmetic backend.

@tarcieri tarcieri force-pushed the ecdsa/replace-check-signature-bytes-with-order branch from 11b3b35 to 3c77746 Compare April 21, 2021 18:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #281 (8763428) into master (89d4dee) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 8763428 differs from pull request most recent head 792f939. Consider uploading reports for the commit 792f939 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   54.66%   54.63%   -0.03%     
==========================================
  Files           8        8              
  Lines         300      291       -9     
==========================================
- Hits          164      159       -5     
+ Misses        136      132       -4     
Impacted Files Coverage Δ
ecdsa/src/hazmat.rs 0.00% <ø> (ø)
ecdsa/src/lib.rs 42.00% <66.66%> (-2.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d4dee...792f939. Read the comment docs.

@tarcieri tarcieri force-pushed the ecdsa/replace-check-signature-bytes-with-order branch 2 times, most recently from 792f939 to c240352 Compare April 21, 2021 18:23
Uses a generic implementation for checking that the scalars in a
signature are in range which doesn't require a curve arithmetic backend.
@tarcieri tarcieri force-pushed the ecdsa/replace-check-signature-bytes-with-order branch from c240352 to 487aae3 Compare April 21, 2021 18:24
@tarcieri tarcieri merged commit 7f3aedd into master Apr 21, 2021
@tarcieri tarcieri deleted the ecdsa/replace-check-signature-bytes-with-order branch April 21, 2021 18:30
@tarcieri tarcieri mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants