dsa: remove use of opaque-debug
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the `Debug` impls in this crate benefit from displaying something, including `SigningKey` which can display its associated `VerifyingKey`. This commit switches to derived `Debug` for all types except `SigningKey`, where it displays the `verifying_key` field then uses `finish_non_exhaustive` to prevent displaying the secret component `x`. They could probably benefit from some better formatting than what the derived implementation provides.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the
Debugimpls in this crate benefit from displaying something, includingSigningKeywhich can display its associatedVerifyingKey.This commit switches to derived
Debugfor all types exceptSigningKey, where it displays theverifying_keyfield then usesfinish_non_exhaustiveto prevent displaying the secret componentx.They could probably benefit from some better formatting than what the derived implementation provides.