ecdsa: add SignatureWithOid
#689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ecdsa/signature-with-oid
branch
from
d49adfb to
70cb20e
Compare
Adds a signature type which is paramaterized by an RFC5758-defined OID identifying the variant of ECDSA used to produce the signature.
tarcieri
force-pushed
the
ecdsa/signature-with-oid
branch
from
70cb20e to
59b4234
Compare
|
The real benefit of this will be dynamically dispatching the hash function to use for verification, but I've left that for a followup PR. |
baloo
reviewed
Apr 3, 2023
|
|
||
| /// Get the ECDSA OID for a given digest OID. | ||
| #[cfg(feature = "digest")] | ||
| const fn ecdsa_oid_for_digest(digest_oid: ObjectIdentifier) -> Option<ObjectIdentifier> { |
There was a problem hiding this comment.
It's private, but accessible via constants (with compile-time failures if given a non-SHA-2 OID, at that)
There was a problem hiding this comment.
I was looking how to do that over in RSA, but this is very cool!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a signature type which is paramaterized by an RFC5758-defined OID identifying the variant of ECDSA used to produce the signature.
cc @baloo @lumag