ecdsa: refactor Signature constructors and improve docs
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements `from_bytes` in terms of `from_scalars`, rather than the other way around. This places the logic for checking that `r` and `s` are nonzero inside of the `from_scalars` method. Additionally improves the documentation to note the various failure cases, i.e. if `r` and/or `s` is out of the range `1..n`, where `n` is the scalar modulus.
tarcieri
force-pushed
the
ecdsa/refactor-constructors-and-improve-documentation
branch
from
94a1e54
to
a2bdb7e
Compare
tarcieri
commented
Jul 8, 2023
| return Err(Error::new()); | ||
| } | ||
|
|
||
| // NOTE: `Signature::from_scalars` checks that both `r` and `s` are non-zero. |
There was a problem hiding this comment.
@fjarri perhaps you could add a comment like this in RustCrypto/elliptic-curves#907 ?
tarcieri
commented
Jul 8, 2023
Comment on lines
+250
to
+251
| let r = ScalarPrimitive::from_slice(&r.into()).map_err(|_| Error::new())?; | ||
| let s = ScalarPrimitive::from_slice(&s.into()).map_err(|_| Error::new())?; |
There was a problem hiding this comment.
In the next breaking release it might make sense to change the r and s parameters to impl Into<ScalarPrimitive<C>> to simplify these conversions.
tarcieri
deleted the
ecdsa/refactor-constructors-and-improve-documentation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
from_bytesin terms offrom_scalars, rather than the other way around.This places the logic for checking that
randsare nonzero inside of thefrom_scalarsmethod.Additionally improves the documentation to note the various failure cases, i.e. if
rand/orsis out of the range1..n, wherenis the scalar modulus.