Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: extract hazmat::{sign_prehashed, verify_prehashed} #731

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

tarcieri
Copy link
Member

Extracts generic, reusable functions from the SignPrimitive and VerifyPrimitive traits.

The main motivation for this is to make it possible for the *Primitive trait impls to be composed in terms of a generic implementation, in order to add support for low-S normalization in the k256 crate.

@tarcieri tarcieri requested a review from fjarri July 17, 2023 01:21
@tarcieri
Copy link
Member Author

tarcieri commented Jul 17, 2023

Note: the intended use of this is to address RustCrypto/elliptic-curves#908. It can also hopefully be used to replace the copy/paste signing implementation in k256 as well.

I think in the next breaking release of ecdsa we can just add low-S normalization support to the ecdsa crate, and with that drop the SignPrimitive/VerifyPrimitive traits.

@tarcieri tarcieri force-pushed the ecdsa/extract-hazmat-sign-and-verify-fns branch 2 times, most recently from 19711ea to db9ceae Compare July 17, 2023 02:02
Extracts generic, reusable functions from the `SignPrimitive` and
`VerifyPrimitive` traits.

The main motivation for this is to make it possible for the `*Primitive`
trait impls to be composed in terms of a generic implementation, in
order to add support for low-S normalization in the `k256` crate.
@tarcieri tarcieri force-pushed the ecdsa/extract-hazmat-sign-and-verify-fns branch from db9ceae to 928c75b Compare July 17, 2023 02:13
@tarcieri tarcieri merged commit d7557a6 into master Jul 17, 2023
8 checks passed
@tarcieri tarcieri deleted the ecdsa/extract-hazmat-sign-and-verify-fns branch July 17, 2023 22:55
@tarcieri tarcieri changed the title ecdsa: extract hazmat::{sign_prehashed, verify_prehashed}. ecdsa: extract hazmat::{sign_prehashed, verify_prehashed} Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants