Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml-dsa: exclude tests/ in published crate due to size #919

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

json420
Copy link
Contributor

@json420 json420 commented Mar 5, 2025

This addresses bug #887 "ml-dsa: large crate size due to test vectors".

The simplest solution is to exclude all of tests/ in the published crate, so that's what my pull request does.

@tarcieri
Copy link
Member

tarcieri commented Mar 5, 2025

I think it would be good to just exclude the tests which rely on the large JSON files, i.e. key-gen, sig-gen, and sig-ver

@json420
Copy link
Contributor Author

json420 commented Mar 5, 2025

Okay, I'll make those changes.

The other kinda large file is proptests.proptest-regressions (415k). Should I exclude that also?

@tarcieri
Copy link
Member

tarcieri commented Mar 5, 2025

Sure, that's fine

@json420
Copy link
Contributor Author

json420 commented Mar 5, 2025

Okay, I updated my pull request to exclude the 3 json files. I also excluded their corresponding .rs files, otherwise those tests fail.

Finally, I'm excluding tests/proptests.proptest-regressions. Removing it doesn't seem to cause any test failures.

@tarcieri tarcieri merged commit a3c9309 into RustCrypto:master Mar 5, 2025
4 checks passed
@tarcieri
Copy link
Member

tarcieri commented Mar 5, 2025

Thanks!

@json420 json420 deleted the json420/ml-dsa/exclude-kat branch March 6, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants