Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salsa20: do not use zeroize default features to prevent alloc inclusion #189

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

Wassasin
Copy link
Contributor

Should be OK as this crate does not use any zeroize alloc functionality.

Stumbled on this when developing embedded firmware, and got the following message during build of the binary:

error: no global memory allocator found but one is required; link to std or add `#[global_allocator]` to a static item that implements the GlobalAlloc trait.

@newpavlov
Copy link
Member

Thank you! Can you please also do the same for hc-256 and rabbit crates?

@tarcieri
We probably should test no_std builds in CI with enabled zeroize feature as well.

@tarcieri
Copy link
Member

@newpavlov yeah, in many of the crates the build job tests various feature combinations, but this one appears to have been overlooked

@tarcieri tarcieri merged commit a38cd0e into RustCrypto:master Nov 12, 2020
@tarcieri
Copy link
Member

I'll take care of hc-256 and rabbit

@tarcieri tarcieri mentioned this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants