-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify KEM API #1509
Merged
Merged
Simplify KEM API #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bifurcation
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rozbb, this refactor looks good to me modulo a couple of small things.
Addressed comments |
tarcieri
approved these changes
Mar 28, 2024
@bifurcation does this look good to you? |
bifurcation
approved these changes
Apr 2, 2024
LGTM! Thanks for the nudge @tarcieri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is neat. So per our conversation in #1508, I simplified everything down to two traits which are highly generic. Some benefits:
SharedSecret
type, or any type for that matterstd
featuregeneric_array
at all (now we don't need to migrate to hybrid-array at this level)Encapsulate
struct have an identity privkey, and yourDecapsulate
struct have an identity pubkey. The X3DH example intests/
shows this isn't hard.One small nit, because I know we've talked about it before: what's the now preferred way to do RNGs? It was between
mut rng: impl CryptoRngCore
orrng: &mut impl CryptoRngCore + ?Sized
.cc @bifurcation