Make PublicKey::from_encoded_point go through PublicKey::from_affine #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's hard to add a regression test for this, because there are no concrete curves we can use to run a test |
|
It'd be fantastic if you could add a regression test for this as well |
|
One way to allow for a regression test is to pull in a curve like |
|
@rozbb yeah this is something of an ongoing problem... no worries! I have a "mock curve" in the Perhaps I should move it to this crate (e.g. in a |
tarcieri
added a commit
that referenced
this pull request
Dec 22, 2020
The invariant of `PublicKey` is that the inner affine point is *NOT* the identity, however there was a bug in the `FromEncodedPoint` implementation which was fixed in #416. However, at the time we couldn't add a regression test because there was no concrete curve type to use for writing such a test. A `MockCurve` was added in #419, so this commit uses it to write such a regression test.
tarcieri
added a commit
that referenced
this pull request
Dec 22, 2020
The invariant of `PublicKey` is that the inner affine point is *NOT* the identity, however there was a bug in the `FromEncodedPoint` implementation which was fixed in #416. However, at the time we couldn't add a regression test because there was no concrete curve type to use for writing such a test. A `MockCurve` was added in #419, so this commit uses it to write such a regression test.
tarcieri
added a commit
that referenced
this pull request
Dec 22, 2020
The invariant of `PublicKey` is that the inner affine point is *NOT* the identity, however there was a bug in the `FromEncodedPoint` implementation which was fixed in #416. However, at the time we couldn't add a regression test because there was no concrete curve type to use for writing such a test. A `MockCurve` was added in #419, so this commit uses it to write such a regression test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415