elliptic-curve: remove direct bitvec dependency
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that zkcrypto/ff#40 is merged, the `ff` crate re-exports the types from `bitvec` that we previously needed to import directly. This means that `elliptic-curve` no-longer needs to depend on the `bitvec` crate directly, but instead we can use it only transitively via the `ff` crate.
tarcieri
force-pushed
the
elliptic-curve/remove-bitvec-dependency
branch
from
afba6b5
to
1045008
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that zkcrypto/ff#40 is merged, the
ffcrate re-exports the types frombitvecthat we previously needed to import directly.This means that
elliptic-curveno-longer needs to depend on thebitveccrate directly, but instead we can use it only transitively via theffcrate.