elliptic-curve: use crypto-bigint to represent Curve::Order
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/use-crypto-bigint-for-order
branch
from
86b591c
to
7bf3d34
Compare
The `crypto_bigint::UInt` type has const-friendly initializers that can parse the curve order from e.g. hexadecimal. This commit changes the `Order` to be represented as a `UInt` type. This also permits things like simplified (and constant time, if needed) comparisons to ensure a given value is in range. Additionally, this commit reimplements the `dev` module's `Scalar` type for `MockCurve` to use a `crypto_bigint::U256` internally.
tarcieri
force-pushed
the
elliptic-curve/use-crypto-bigint-for-order
branch
from
7bf3d34
to
994b8ef
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crypto_bigint::UInttype has const-friendly initializers that can parse the curve order from e.g. hexadecimal.This commit changes the
Orderto be represented as aUInttype. This also permits things like simplified (and constant time, if needed) comparisons to ensure a given value is in range.Additionally, this commit reimplements the
devmodule'sScalartype forMockCurveto use acrypto_bigint::U256internally.