elliptic-curve: source FieldSize from Curve::UInt type #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `crypto-bigint` library defines an associated `ArrayLength<u8>` for every `UInt` type as part of the `ArrayEncoding` trait. This means we don't need to define both: we can now source what was previously `C::FieldSize` via `C::UInt::ByteSize`. This commit performs that replacement, adding a `FieldSize<C>` type alias which can be used anywhere `C::FieldSize` was previously used which sources the `ArrayLength<u8>` from `C::UInt` instead.
tarcieri
force-pushed
the
elliptic-curve/source-field-size-from-curve-uint-type
branch
from
cb33742
to
1ae4c70
Compare
tarcieri
deleted the
elliptic-curve/source-field-size-from-curve-uint-type
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crypto-bigintlibrary defines an associatedArrayLength<u8>for everyUInttype as part of theArrayEncodingtrait.This means we don't need to define both: we can now source what was previously
C::FieldSizeviaC::UInt::ByteSize.This commit performs that replacement, adding a
FieldSize<C>type alias which can be used anywhereC::FieldSizewas previously used which sources theArrayLength<u8>fromC::UIntinstead.