elliptic-curve: make ScalarBytes<C> the SecretKey<C> internal repr #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously SecretKey<C> had a generic internal value, depending on whether or not the `arithmetic` feature was activated. This was mostly trying to work around the fact that there wasn't a baseline arithmetic impl available to validate secret keys. Now there is! SecretBytes<C> uses C::UInt and its may features as a `crypto-bigint` to always validate the internal bytes. This means we can simply use `SecretBytes<C>` as the inner value of a `SecretKey<C>`, and still provide infallible conversions to `NonZeroScalar<C>`.
tarcieri
force-pushed
the
elliptic-curve/use-secretbytes-as-secretkey-inner-value
branch
from
03bfa97
to
97269d5
Compare
tarcieri
deleted the
elliptic-curve/use-secretbytes-as-secretkey-inner-value
branch
This was referenced Jun 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SecretKey had a generic internal value, depending on whether or not the
arithmeticfeature was activated. This was mostly trying to work around the fact that there wasn't a baseline arithmetic impl available to validate secret keys.Now there is! SecretBytes uses C::UInt and its may features as a
crypto-bigintto always validate the internal bytes.This means we can simply use
SecretBytes<C>as the inner value of aSecretKey<C>, and still provide infallible conversions toNonZeroScalar<C>.