feat: add hash to field #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lodder <redmike7@gmail.com>
tarcieri
reviewed
Jan 3, 2022
| @@ -47,6 +48,7 @@ arithmetic = ["ff", "group"] | |||
| bits = ["arithmetic", "ff/bits"] | |||
| dev = ["arithmetic", "hex-literal", "pem", "pkcs8"] | |||
| ecdh = ["arithmetic"] | |||
| hashing = ["digest"] | |||
There was a problem hiding this comment.
Elsewhere in RustCrypto we generally just keep digest-related functionality gated behind the digest feature
tarcieri
reviewed
Jan 3, 2022
|
Going to go ahead and merge this. Can fix up While I do have some general concerns about how this is structured, I think trying to play with some alternatives really needs to have everything wired up with concrete implementations in the |
This was referenced Jan 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream hash2field as described in PR 495