Implement ZeroizeOnDrop on appropriate items
#884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to bump the That said, it shouldn't be a breaking change. |
daxpedda
force-pushed
the
zeroize-on-drop
branch
from
fad7b14
to
1c2618b
Compare
|
I already had in |
|
If I realized that it wasn't a breaking change, I would have said something before the release. Any chance we can still get this out? |
|
Thanks! |
I can cut one more release of |
Merged
|
|
tarcieri
added a commit
that referenced
this pull request
Jan 27, 2022
We've received a number of complaints about `zeroize` compatibility (see RustCrypto/utils#723), which was exacerbated by #884 which bumped the `zeroize` version within a minor version series. I had hoped the cargo resolver would've been able to select an older compatible version of zeroize in these cases, but I've gotten a lot of reports that isn't happening. This release reverts #884 in hopes of supporting a wider range of `zeroize` versions for now. It's technically breaking in the event anyone is actually depending on `ZeroizeOnDrop` marker traits on these types, but it seems we've already broken things for current users and that's the much higher impact issue.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming this is a breaking change.