Skip to content

Commit

Permalink
zeroize: add #[ignore] to flaky CString test (#776)
Browse files Browse the repository at this point in the history
This test relies on UB and is flaking out in certain cases:

#774

It's unclear if the test failure indicates a genuine bug in the
implementation, or is the result of a test with UB.

However, in the meantime it shouldn't block users who would just like
the test suite to run reliably.
  • Loading branch information
tarcieri committed Jun 29, 2022
1 parent a511710 commit cee7946
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions zeroize/tests/zeroize.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ fn zeroize_string_entire_capacity() {
assert!(as_vec.iter().all(|byte| *byte == 0));
}

// TODO(tarcieri): debug flaky test (with potential UB?) See: RustCrypto/utils#774
#[cfg(feature = "std")]
#[ignore]
#[test]
fn zeroize_c_string() {
let mut cstring = CString::new("Hello, world!").expect("CString::new failed");
Expand Down

0 comments on commit cee7946

Please sign in to comment.