Skip to content

block-padding: remove PadType and add pad_detached method #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 26, 2025
Merged

block-padding: remove PadType and add pad_detached method #1225

merged 11 commits into from
Sep 26, 2025

Conversation

@newpavlov
Copy link
Member

@newpavlov newpavlov commented Sep 23, 2025 •
edited
Loading

PadType is used only in the default implementation of unpad_blocks and in inout. To handle the latter case Padding::pad_detached is added.

@newpavlov
Copy link
Member Author

newpavlov commented Sep 23, 2025

PadType is used in inout, I will look into whether it's necessary.

@newpavlov newpavlov changed the title block-padding: remove PadType block-padding: remove PadType and add pad_detached method Sep 26, 2025
@newpavlov newpavlov merged commit 1b849b1 into master Sep 26, 2025
100 checks passed
@newpavlov newpavlov deleted the block-padding/rm_pad_type branch September 26, 2025 07:44
@newpavlov newpavlov mentioned this pull request Sep 26, 2025
Merged
@newpavlov newpavlov mentioned this pull request Oct 6, 2025
Merged
newpavlov added a commit that referenced this pull request Oct 6, 2025
@newpavlov
Release block-padding v0.4.0 (#1233)
e0020c5 
### Added
- `Padding::pad_detached` method ([#1225])

### Changed
- Migrated from `generic-array` to `hybrid-array` ([#944])
- Edition changed to 2024 and MSRV bumped to 1.85 ([#1149])
- Merged `RawPadding` and `Padding` traits ([#1217])
- Renamed `UnpadError` to `Error` ([#1225])

### Removed
- `Block` type alias ([#1217])
- `PadType` enum and associated type on the `Padding` trait ([#1225])

[#944]: #944
[#1149]: #1149
[#1217]: #1217
[#1225]: #1225
newpavlov added a commit that referenced this pull request Oct 6, 2025
@newpavlov
block-padding: fix pad_detached for NoPadding and ZeroPadding (#…
9118661 
…1227)

In #1225 I forgot to overwrite the default implementation of
`pad_detached` for `NoPadding` and `ZeroPadding`.

Additionally, this PR adds `PaddedData` enum to make return type of
`pad_detached` less complex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@newpavlov @tarcieri