Correct use of result.duration and "registration" for State documents #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes existing test which was failing on now conformant LRS * Make 'registration' nullable in StateDocument * Add setting registration value in query params and properties for certain State requests which should have already had it
* Fixes failing test for About resource because of unrecognized versions * Added new property for tracking "known" versions separate from "supported" versions * Added 0.9 and 0.95 to new "known" list as they may be /about response * Switched operator to look at known vs supported version list
* "duration" property was always populated otherwise with 0 duration * Add basic tests for serialization/deserialization
bscSCORM
added a commit
that referenced
this pull request
Mar 12, 2015
Correct use of result.duration and "registration" for State documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass now (again)! Submitting straight to you Ben since these are pretty straightforward for review. Once merged I'll tag and release a new version with updated AssemblyInfo.