-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump compats (including julia), remove unneeded Interpolations.jl dep #23
Conversation
palumbom
commented
Jan 23, 2025
- Removed Interpolations dependency (it was not used)
- Added compat entries for Julia 1.10 and 1.11
- Other bumped compats (intermediate versions since last release not tested)
- DataFrames 1.7
- NaNMath 2.5
- SpecialFunctions 2.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably from before I moved that out into a separate RvSpectML package.
This looks good. As long as tests pass, we should be good to go.
^Tests pass, but docs fail I'm not a collaborator on this repo, so you'll have to merge yourself or add me as one. |
Mind drafting a new release? Then I'll bump the compat + draft a release for EchelleCCFs. Thanks! |
I tried. It looks like the error on building the docs is preventing the new versions. I might find time to fix it this weekend, but it you can probably fix it faster. (Sorry, I know it's not due to your change.) |
Oh, somehow it did go through. Thanks if you did something to let it. |
Hm, I didn't do anything but oh well :) Looks like it's merged in, but no tagged release yet. I can take care of it (and also try to figure out the docs issue) if you invite me as a collaborator. |
Thanks. Done
…On Fri, Jan 24, 2025 at 10:33 AM Michael Palumbo ***@***.***> wrote:
Hm, I didn't do anything but oh well :)
Looks like it's merged in, but no tagged release yet. I can take care of
it (and also try to figure out the docs issue) if you invite me as a
collaborator.
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKDFQQEUGY5QLEVOKFIFTL2MJMLLAVCNFSM6AAAAABVYA2ATGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJSHAYDQMRSGE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Eric Ford
|