Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compats (including julia), remove unneeded Interpolations.jl dep #23

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

palumbom
Copy link
Collaborator

  • Removed Interpolations dependency (it was not used)
  • Added compat entries for Julia 1.10 and 1.11
  • Other bumped compats (intermediate versions since last release not tested)
    • DataFrames 1.7
    • NaNMath 2.5
    • SpecialFunctions 2.5

Copy link
Member

@eford eford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably from before I moved that out into a separate RvSpectML package.
This looks good. As long as tests pass, we should be good to go.

@palumbom
Copy link
Collaborator Author

^Tests pass, but docs fail

I'm not a collaborator on this repo, so you'll have to merge yourself or add me as one.

@eford eford merged commit 5e6611d into RvSpectML:main Jan 23, 2025
1 of 2 checks passed
@palumbom
Copy link
Collaborator Author

Mind drafting a new release? Then I'll bump the compat + draft a release for EchelleCCFs. Thanks!

@eford
Copy link
Member

eford commented Jan 24, 2025

I tried. It looks like the error on building the docs is preventing the new versions. I might find time to fix it this weekend, but it you can probably fix it faster. (Sorry, I know it's not due to your change.)

@eford
Copy link
Member

eford commented Jan 24, 2025

Oh, somehow it did go through. Thanks if you did something to let it.

@palumbom
Copy link
Collaborator Author

Hm, I didn't do anything but oh well :)

Looks like it's merged in, but no tagged release yet. I can take care of it (and also try to figure out the docs issue) if you invite me as a collaborator.

@eford
Copy link
Member

eford commented Jan 24, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants