Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fix #22

Closed
wants to merge 6 commits into from
Closed

CI Fix #22

wants to merge 6 commits into from

Conversation

ashfurrow
Copy link
Member

Two parts:

@orta
Copy link
Member

orta commented Apr 20, 2016

The optimal 1.0 podfile for this is:

use_frameworks!

target 'RxOptional Examples' do
  pod 'RxOptional', :path => '../'
  pod 'RxSwift', '~> 2.0'
  pod 'RxCocoa', '~> 2.0'

  target 'RxOptional Tests' do
    inherit! :search_paths
    pod 'Quick'
    pod 'Nimble', :git => 'https://github.com/ashfurrow/Nimble.git', :branch => 'podspec-update'
  end
end

@ashfurrow
Copy link
Member Author

Mmm good point.

@orta
Copy link
Member

orta commented Apr 20, 2016

That's a niggle, good to merge regardless of that 👍

@ashfurrow
Copy link
Member Author

Nah, I noticed Podfile.lock was missing, might as well add that here too. Might prevent future CI breaks.

@ashfurrow
Copy link
Member Author

Hmm, now it's red.

@ashfurrow
Copy link
Member Author

Reproduced locally, looks like it's iPhone 4S-only, maybe a 32-bit problem.

@orta
Copy link
Member

orta commented Apr 20, 2016

potentially useful aside: cache: cocoapods is happening on travis too

@ashfurrow
Copy link
Member Author

I'm not really up for dealing with weird CI-only failures, I've merged in 665b1a2 (the last green commit in this PR) and a subsequent addition of Podfile.lock (went green on CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants