-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Observable namespace for Swift5.9/XCode15 conflict #202
Conversation
Thanks a lot for contributing @arshiacont! I've invited you to join the Generated by 🚫 dangerJS |
@JoeMatt this PR is a no brainer and solves the XCode 15 issue... . |
Any update on the progress or remaining requirements for this to be merged? |
@JoeMatt Possible to release a hotfix 5.0.6? (thanks for approval) |
Tonight. Finally have a break on the rain around here. |
wanna add the iOS 12 minimum version bump too? |
Please publish it 💯 |
Until either @JoeMatt or @freak4pc merge this and update the PodSpec all of y'all (@asn111 ?) who are using CocoaPods and have updated to macOS Sonoma, which prevents you from using Xcode 14, can just point to the branch of this fix in the I'm able to build and run my app fine on macOS 14 with Xcode 15. |
Can you merge this ? @JoeMatt |
@arshiacont Able to fix the pipeline before we merge this? |
@rynecheow the pipeline errors seems to be a dependency issue and independent of any PR... . @JoeMatt you kindly approved the changes last week amid rain! :) If you could merge to the main branch it'll avoid people to point to my Fork (which is probably not right!). Getting an SPM/Pod release would be best. |
Hi team, could you check to release this ? |
@JoeMatt |
@JoeMatt Possible to release? |
@JoeMatt |
Stop commenting and tagging every 15 minutes, this is seriously disrespectful. This project isn't maintained as was noted before and people are volunteering their free time to try and assist. If you're under a time crunch just direct your project to the specific tag / commit and move on until this is resolved. |
Just updated Cocoapod dependency in the workflow hoping this will pass the checks and we can have a smooth release. Pending workflow approval and final check, we might want to modify other dependencies... . |
Is the iOS 11.0 vs 12.0 dependency issue fixed as well? That's causing some build issues for us. We had to bump the minimum manually |
@yspreen I would create a separate issue on that. Focusing on getting this one over with. |
the tl;dr here is that - if someone wants to take over and maintain this project, we're happy to add a second owner to take care of it. If not, it might take a bit of time due to time (and war) constraints. |
It would be great if you will add someone as an owner, I can help with this stuff. You can add me |
I can help to approve this and merge, provided the pipeline is green :) Able to help fixing the pipeline error please? Seems like a Cocoapods iOS demo issue |
Just a hint: There is apparently a problem with the version of the dependency |
@arshiacont yes you are right, it is related to the latest version of as a temporary workaround could we try to add |
@lihao6485 @rynecheow just moved Cocoapod dependency to 1.14.0 (released yesterday) that addresses the ActiveSupport crash. Hopefully this will fix the workflow for this PR. |
@arshiacont I have fixed the CI build issue, could you try to merge this PR in your branch and run the CI again? |
Done! Awaiting approval |
Thanks for merging! |
changed several
Observable
types toRxSwift.Observable
to overcome XCode 15 conflict#trivial
fixes #199 and #201