Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observable namespace for Swift5.9/XCode15 conflict #202

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

arshiacont
Copy link
Contributor

@arshiacont arshiacont commented Sep 22, 2023

changed several Observable types to RxSwift.Observable to overcome XCode 15 conflict

#trivial
fixes #199 and #201

@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Sep 22, 2023

Thanks a lot for contributing @arshiacont! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@arshiacont
Copy link
Contributor Author

@JoeMatt this PR is a no brainer and solves the XCode 15 issue... .

@erikmartens
Copy link

Any update on the progress or remaining requirements for this to be merged?

@arshiacont
Copy link
Contributor Author

Any update on the progress or remaining requirements for this to be merged?

A maintainer for the repo is needed here.. @JoeMatt @freak4pc ?

@JoeMatt JoeMatt self-assigned this Sep 27, 2023
@JoeMatt JoeMatt self-requested a review September 27, 2023 01:00
@asn111
Copy link

asn111 commented Sep 27, 2023

I am also unable to load my project and these are the issues it displays.
Any idea how to fix these?
Thanks 🙏

Screenshot 2023-09-27 at 8 37 05 PM

@arshiacont
Copy link
Contributor Author

@JoeMatt Possible to release a hotfix 5.0.6? (thanks for approval)

@JoeMatt
Copy link
Contributor

JoeMatt commented Sep 27, 2023

Tonight. Finally have a break on the rain around here.

@yspreen
Copy link

yspreen commented Sep 30, 2023

wanna add the iOS 12 minimum version bump too?

@hoc081098
Copy link

Please publish it 💯

@erikmartens
Copy link

erikmartens commented Oct 3, 2023

Until either @JoeMatt or @freak4pc merge this and update the PodSpec all of y'all (@asn111 ?) who are using CocoaPods and have updated to macOS Sonoma, which prevents you from using Xcode 14, can just point to the branch of this fix in the Podfile by using pod 'RxRealm', :git => 'https://github.com/arshiacont/RxRealm.git', :branch => 'bugfix/xcode15', :commit => 'ec4ac63'

I'm able to build and run my app fine on macOS 14 with Xcode 15.

@imvityalee
Copy link

imvityalee commented Oct 4, 2023

Can you merge this ? @JoeMatt

@rynecheow
Copy link
Member

@arshiacont Able to fix the pipeline before we merge this?

@arshiacont
Copy link
Contributor Author

@arshiacont Able to fix the pipeline before we merge this?

@rynecheow the pipeline errors seems to be a dependency issue and independent of any PR... .

@JoeMatt you kindly approved the changes last week amid rain! :) If you could merge to the main branch it'll avoid people to point to my Fork (which is probably not right!). Getting an SPM/Pod release would be best.

@diegothucao
Copy link

Hi team, could you check to release this ?

@s14228so
Copy link

@JoeMatt
Please publish it🙇🙏

@Tom0430
Copy link

Tom0430 commented Oct 10, 2023

@JoeMatt Possible to release?

@ibukiblue
Copy link

@JoeMatt
Is there some problem that makes it impossible to release?🫠

@freak4pc
Copy link
Member

Stop commenting and tagging every 15 minutes, this is seriously disrespectful. This project isn't maintained as was noted before and people are volunteering their free time to try and assist. If you're under a time crunch just direct your project to the specific tag / commit and move on until this is resolved.

@arshiacont
Copy link
Contributor Author

Just updated Cocoapod dependency in the workflow hoping this will pass the checks and we can have a smooth release. Pending workflow approval and final check, we might want to modify other dependencies... .

@yspreen
Copy link

yspreen commented Oct 10, 2023

Is the iOS 11.0 vs 12.0 dependency issue fixed as well? That's causing some build issues for us. We had to bump the minimum manually

@arshiacont
Copy link
Contributor Author

Is the iOS 11.0 vs 12.0 dependency issue fixed as well? That's causing some build issues for us. We had to bump the minimum manually

@yspreen I would create a separate issue on that. Focusing on getting this one over with.

@freak4pc
Copy link
Member

the tl;dr here is that - if someone wants to take over and maintain this project, we're happy to add a second owner to take care of it. If not, it might take a bit of time due to time (and war) constraints.

@imvityalee
Copy link

the tl;dr here is that - if someone wants to take over and maintain this project, we're happy to add a second owner to take care of it. If not, it might take a bit of time due to time (and war) constraints.

It would be great if you will add someone as an owner, I can help with this stuff. You can add me

@rynecheow
Copy link
Member

I can help to approve this and merge, provided the pipeline is green :) Able to help fixing the pipeline error please? Seems like a Cocoapods iOS demo issue

@arshiacont
Copy link
Contributor Author

I can help to approve this and merge, provided the pipeline is green :) Able to help fixing the pipeline error please? Seems like a Cocoapods iOS demo issue

Just a hint: There is apparently a problem with the version of the dependency activesupport used here... I had this on my local machine which was solved by just fixing the version to what was required by Cocoapods... but I did not dig into how we can solve it on this project.

@lihao6485
Copy link
Contributor

lihao6485 commented Oct 24, 2023

@arshiacont yes you are right, it is related to the latest version of activesupport (7.1.0)
CocoaPods/CocoaPods#12081

as a temporary workaround could we try to add gem 'activesupport', '>= 6.1.7.3', '< 7.1.0' into gemfile in this PR?

@arshiacont
Copy link
Contributor Author

@lihao6485 @rynecheow just moved Cocoapod dependency to 1.14.0 (released yesterday) that addresses the ActiveSupport crash. Hopefully this will fix the workflow for this PR.

@lihao6485
Copy link
Contributor

@arshiacont I have fixed the CI build issue, could you try to merge this PR in your branch and run the CI again?
arshiacont#1

@arshiacont
Copy link
Contributor Author

@arshiacont I have fixed the CI build issue, could you try to merge this PR in your branch and run the CI again?

arshiacont#1

Done! Awaiting approval

@lihao6485 lihao6485 merged commit 343ad4c into RxSwiftCommunity:main Oct 29, 2023
2 checks passed
@fpedro23
Copy link

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with Xcode 15