refactor(edition): Rust 2024 migration + agent-teams-rs integration#65
Merged
RyderFreeman4Logos merged 9 commits intomainfrom Feb 13, 2026
Merged
Conversation
[MOTIVATION] Upgrade to Rust 2024 edition to enable direct dependency on agent-teams-rs crates which require edition 2024 and Rust 1.85+. [IMPLEMENTATION DETAILS] - Updated all Cargo.toml files to edition 2024 - Set rust-version to 1.85 - Fixed any edition 2024 breaking changes Co-Authored-By: Claude <noreply@anthropic.com>
[MOTIVATION] Chinese/multi-byte UTF-8 descriptions cause panic when truncated at non-char-boundary byte offsets during session listing. [IMPLEMENTATION DETAILS] - Use char-boundary-safe truncation for session descriptions - Add test for multi-byte UTF-8 truncation edge cases Co-Authored-By: Claude <noreply@anthropic.com>
…e on resume [MOTIVATION] Users should only interact with CSA meta session IDs. Provider session IDs (e.g., Codex UUIDs) are internal implementation details that should not be exposed to users. [IMPLEMENTATION DETAILS] - Ensure csa debate outputs CSA meta session ID (not provider ID) - Session resume resolves provider ID internally from state.toml - Add tests for session ID resolution Co-Authored-By: Claude <noreply@anthropic.com>
…ing tree [MOTIVATION] After , running showed "No changes" because it compared working tree vs last commit. Users expect to see what changed in the most recent save. [IMPLEMENTATION DETAILS] - When no uncommitted changes exist, default to comparing last two saves - Preserve current behavior when uncommitted changes are present - Add tests for post-save default diff behavior Co-Authored-By: Claude <noreply@anthropic.com>
[MOTIVATION] Directly depend on agent-teams-rs to leverage its AgentBackend/AgentSession trait abstractions and pure-function consensus module. [IMPLEMENTATION DETAILS] - Add agent-teams-rs as path dependency - Create adapter bridging CSA executor to AgentBackend trait - Re-export consensus types for use in csa review - Additive integration — no existing behavior changes Co-Authored-By: Claude <noreply@anthropic.com>
[MOTIVATION] Visualize task dependencies in TODO plans to understand execution order, identify critical paths, and detect circular dependencies. [IMPLEMENTATION DETAILS] - Add DependencyGraph with BFS cycle detection and topological sort - Parse dependency annotations from TODO markdown - Add subcommand with mermaid/terminal/dot output - Add comprehensive tests for graph operations Co-Authored-By: Claude <noreply@anthropic.com>
…r aggregation [MOTIVATION] Enable running multiple reviewers with consensus-based verdict aggregation to improve review reliability through cognitive diversity. [IMPLEMENTATION DETAILS] - Add --reviewers N and --consensus flags to csa review - Parallel multi-reviewer execution with round-robin tool selection - Consensus resolution via agent-teams-rs (majority/weighted/unanimous) - Single reviewer mode unchanged for backward compatibility Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-teams-rsas workspace dependency for backend traits and consensuscsa todo diffempty defaultcsa todo dag) with Mermaid/terminal/DOT outputcsa review(--reviewers N --consensus <strategy>)Changes (7 commits, 44 files, +3276/-469)
chore(edition): Migrate all crates to Rust 2024 —genkeyword reservation,ref/ref mutpatterns,map_or→is_none_or,unsafe externblocksfix(session): Char-boundary-safe truncation for session descriptions — prevents panic on multi-byte UTF-8fix(session): Resolve provider session ID internally fromstate.tomlon resume — CSA meta session IDs are now the only user-facing identifierfix(todo): Defaultcsa todo diffshows last save changes instead of empty working treefeat(executor): NewExecutorAgentBackendimplementingAgentBackend/AgentSessiontraits from agent-teams-rs; consensus re-exports in csa-corefeat(todo): DAG dependency graph with BFS cycle detection, Kahn's topological sort, Mermaid/terminal/DOT visualizationfeat(consensus): Multi-reviewer orchestration with round-robin tool selection, verdict parsing, and configurable consensus strategies (majority/unanimous/weighted)Test plan
just pre-commitpasses on all commitscargo clippy -- -D warningscleancargo testpasses across all crates🤖 Generated with Claude Code