feat(workspace): opt-in cc-sdk feature passthrough (#sprint6)#69
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Feb 13, 2026
Merged
feat(workspace): opt-in cc-sdk feature passthrough (#sprint6)#69RyderFreeman4Logos merged 1 commit intomainfrom
RyderFreeman4Logos merged 1 commit intomainfrom
Conversation
[MOTIVATION] agent-teams-rs cc-sdk dependency (Claude Code SDK) pulls in heavy deps that are unused at runtime — CSA uses subprocess execution, not the SDK library. Making it optional reduces compile time and binary size. [IMPLEMENTATION DETAILS] - Workspace root: agent-teams uses default-features = false - csa-executor: forwards cc-sdk feature to agent-teams/cc-sdk - cli-sub-agent: forwards cc-sdk feature to csa-executor/cc-sdk - Verified compilation in both modes (default + --features cc-sdk) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-teamscc-sdk dependency optional via Cargo feature flagscc-sdkfeature through the crate chain:cli-sub-agent → csa-executor → agent-teamsagent-teamswithdefault-features = falseto avoid pulling in cc-sdk at compile timeTest plan
cargo check— compiles without cc-sdk (default)cargo check --features cc-sdk— compiles with cc-sdk enabledjust pre-commit— 849 unit + 8 E2E tests pass, clippy cleancsa review --diff— zero findingscsa review --branch main— zero findings, low risk🤖 Generated with Claude Code