Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testsuite fails with Minitest 5.20 #84

Open
mtasaka opened this issue Oct 31, 2023 · 0 comments · May be fixed by #85
Open

Testsuite fails with Minitest 5.20 #84

mtasaka opened this issue Oct 31, 2023 · 0 comments · May be fixed by #85

Comments

@mtasaka
Copy link

mtasaka commented Oct 31, 2023

As of clockwork git head ( 7ed9042 ),
testsuite fails with Minitest 5.20 as:

$ ruby -Ilib:test -rclockwork -e "Dir.glob('./test/**/*_test.rb').sort.each {|t| require t}"
Loaded suite -e
Started

  1) Error:
Clockwork::Manager#test_0012_exceptions are trapped and logged:
NameError: uninitialized constant MiniTest
    /builddir/build/GIT/clockwork/test/manager_test.rb:120:in `block (2 levels) in <top (required)>'

93 runs, 168 assertions, 0 failures, 1 errors, 0 skips

Already for a long while "Minitest" usage is preferred and with 5.19 "MiniTest" usage
is hidden by default.
mtasaka added a commit to mtasaka/clockwork that referenced this issue Oct 31, 2023
@mtasaka
Test: use recent Minitest style
d1515e6 
Current style has long been to use Minitest instead of MiniTest,
and with minitest 5.19, MiniTest usage support is
hidden unless explicitly setting ENV["MT_COMPAT"].

minitest/minitest@a2c6c18

Use Minitest instead of MiniTest .

Closes Rykian#84 .
@mtasaka mtasaka linked a pull request Oct 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test: use recent Minitest style mtasaka/clockwork
1 participant
@mtasaka