Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different equality tester of scales #23

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Use different equality tester of scales #23

merged 1 commit into from
Feb 8, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break tvthemes.

We changed the internals of scales a bit to provide more accurate error messages. Unfortunately, this makes testing for the equality of scales a bit more difficult. This PR updates the tests to ignore the call field of scales. In addition, a few tests for the scale_name field were deleted, as this field is to become deprecated in the new ggplot2 version.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help tvthemes get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is just a kind reminder that the release of ggplot2 is scheduled soon.

@Ryo-N7 Ryo-N7 merged commit ba372ca into Ryo-N7:master Feb 8, 2024
@Ryo-N7
Copy link
Owner

Ryo-N7 commented Feb 8, 2024

thanks, done!

@teunbrand teunbrand deleted the ggplot2_3.5.0 branch February 8, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants