Skip to content

Fix Arduino Nano 33 BLE build #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Arduino Nano 33 BLE build #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
023bb1c
ignore setting storage for RP2040 for now
SunboX Jun 15, 2022
93abbf2
check for all RP2040 boards
SunboX Jun 15, 2022
5e597ac
add missing def check
SunboX Jun 15, 2022
8e1b0c6
Draft support for Arduino Nano 33 BLE (disable EEPROM)
spotman Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ sentence=Arduino Library for piezo sensing
paragraph=By combining with the MIDI library, you can easily create MIDI converters. By combining with Teensy audio, you can easily create synth drums.
category=Sensors
url=https://github.com/RyoKosaka/HelloDrum-arduino-Library
architectures=avr,teensy,esp32
architectures=avr,teensy,esp32,mbed_nano
includes=hellodrum.h
20 changes: 17 additions & 3 deletions src/hellodrum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
#include "hellodrum.h"
#include "Arduino.h"

#ifdef ESP32
#if ( defined(ARDUINO_ARCH_RP2040) || defined(ARDUINO_RASPBERRY_PI_PICO) || defined(ARDUINO_ADAFRUIT_FEATHER_RP2040) || defined(ARDUINO_GENERIC_RP2040) || defined(NRF52840_XXAA) )
// ignore for now
//ToDo: Implement EEPROM handler for RP2040, see https://arduino-pico.readthedocs.io/en/latest/eeprom.html#eeprom-examples
#elif defined(ESP32)
#include "EEPROM_ESP.h"
#else
#include "EEPROM.h"
Expand Down Expand Up @@ -1352,7 +1355,12 @@ void HelloDrum::hihatControlMUX()

//////////////////////////// 6. EEPROM SETTING //////////////////////////////

#ifdef ESP32
#if ( defined(ARDUINO_ARCH_RP2040) || defined(ARDUINO_RASPBERRY_PI_PICO) || defined(ARDUINO_ADAFRUIT_FEATHER_RP2040) || defined(ARDUINO_GENERIC_RP2040) || defined(NRF52840_XXAA) )

// ignore for now
//ToDo: Implement EEPROM handler for RP2040, see https://arduino-pico.readthedocs.io/en/latest/eeprom.html#eeprom-examples

#elif defined(ESP32)

void HelloDrum::settingEnable()
{
Expand Down Expand Up @@ -1921,7 +1929,13 @@ void HelloDrum::settingName(const char *instrumentName)
nameIndex++;
}

#ifdef ESP32

#if ( defined(ARDUINO_ARCH_RP2040) || defined(ARDUINO_RASPBERRY_PI_PICO) || defined(ARDUINO_ADAFRUIT_FEATHER_RP2040) || defined(ARDUINO_GENERIC_RP2040) || defined(NRF52840_XXAA) )

// ignore for now
//ToDo: Implement EEPROM handler for RP2040, see https://arduino-pico.readthedocs.io/en/latest/eeprom.html#eeprom-examples

#elif defined(ESP32)

void HelloDrum::loadMemory()
{
Expand Down
5 changes: 4 additions & 1 deletion src/hellodrum.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@

#include "Arduino.h"

#ifdef ESP32
#if ( defined(ARDUINO_ARCH_RP2040) || defined(ARDUINO_RASPBERRY_PI_PICO) || defined(ARDUINO_ADAFRUIT_FEATHER_RP2040) || defined(ARDUINO_GENERIC_RP2040) || defined(NRF52840_XXAA) )
// ignore for now
//ToDo: Implement EEPROM handler for RP2040, see https://arduino-pico.readthedocs.io/en/latest/eeprom.html#eeprom-examples
#elif defined(ESP32)
#include "EEPROM_ESP.h"
#else
#include "EEPROM.h"
Expand Down