-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/serialization rewrite #387
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reviewing all my old changes * messing around, I seem to be getting a cyclical redefine error * glyn, fixed things, yay * serializing is working, deserializing is getting there * We can now serialize simple structs. To do more complex things, the reflector needs to be improved. Next i'll work on a syntax upgrade * implemented a method of serializing everything an entity has (apart from components) I will be finishing this up soon, and moving to scenemanagement * constexpr problems * having some issues with deserializing containers When the compiler is trying to create templated versions for my deserialization functions, it trys to use the deserialize_container<T>() method on id_types, which gives errors. Even though I have a check to see if the value is even an array or not. I think the fix is constexpr but im not too familar with it * reorganizing * Next is component serialization/deserialization * still figuring out components * we now check if a value is a literal or a container before entering a recursive serialization loop * entities are now reflectors * gave hashed_sparse_set a value_type static memeber, everything should be serializaing properly, apart from entity component compositions * I need to do a redesign of the serializer, view, registry model ive got going. * im doing some whaccky stuff rn * updating work * figuring stuff out * updated our design, and re thought some things * individual serializer_views updated * implemented error checking * design should be set in place. Just working out some kinks * we are running, but there are some serious issues that still need to be resolved * fork being weird * applying references properly (i think) * remove_cvr_t is magic * trying to create a way to check whether a type is container at compile time. very close * still messing around with the structs * fixed typo in decltypes(...), improved is_container, added is_resizable_container * problem with is_container * fixed a COMMA macro issue, but is_container seems to defaulting to false * i got is container to work * i am serializing, but the formating is messed up * testing out formatting * heirarchies are difficult * we are serializing. Havving a bit of trouble with common::result but ill fix that another time * the only thing that needs to be serialized now is components * why is serialize returning false for ints * creating a is_serializable * Everything is being serialized. Components, Entities, Containers, materials, probably * and we've got problems yay * lemme mess up all your code * in the process of making some changes to the architecture based on feedback * implementing some new designs * containers are fucked * new designs implemented. now to start deserializing * got feedback on the api, will probably implement it tomorrow * new api implemented but i messed up my vcxproj gotta go fix now * there are problems. Idk how fix. I go sleep * Designed and setup deserialization API * deserialization is on its way * having trouble getting the type of component when we deserialize * components are deserializaing properly now. Found a small bug in children deserialization, gonna fix that tomorrow * test pipeline * fix some rebase issues, remove local hash and name, serializer api rework to remove allocations, const correctness, fixes in serializer, start using new reflector * make compile * working json, bson, and yaml serialization and deserialization * change the way containers are serialized * undo broken meta changes from rebase * erase remnants of cereal * adress PR and build issues * fix duplicate dtor * remove redundant typename keywords * fix error in filesystem unit tests Co-authored-by: Rowan Ramsey <blazinram@gmail.com> Co-authored-by: Rowan Ramsey <501238@student.saxion.nl>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.