Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slightly improve README.md and CLI description #5

Merged
merged 2 commits into from
Dec 11, 2022

Conversation

EnokiUN
Copy link
Contributor

@EnokiUN EnokiUN commented Dec 10, 2022

edit: after a bit of thinking I realised that this could be interpreted in a somewhat offensive/disrespectful manner and I prematurely appologise if it does come as so and do understand if it gets merged without any prior warning.

Thanks for the great work and gl with all your projects!

@gitguardian
Copy link

gitguardian bot commented Dec 10, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- GitHub Access Token 3eaaed2 src/main.rs View secret
- GitHub Access Token dd6ad06 src/main.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@EnokiUN
Copy link
Contributor Author

EnokiUN commented Dec 10, 2022

well frick

@EnokiUN
Copy link
Contributor Author

EnokiUN commented Dec 10, 2022

should be alright now

@Ryu0118 Ryu0118 merged commit 9ddbb0c into Ryu0118:main Dec 11, 2022
@Ryu0118
Copy link
Owner

Ryu0118 commented Dec 11, 2022

Thanks your contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants