Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the Metal Experiment #701

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Revert the Metal Experiment #701

merged 4 commits into from
Feb 23, 2025

Conversation

GreemDev
Copy link
Member

@GreemDev GreemDev commented Feb 22, 2025

Metal sounded like a good idea to get in the emulator but frankly I underestimated just how experimental and not ready it was.
From my write up in the Discord:

As is, Metal supports only a few games.
The games it does support freeze on first use of not playing them via Vulkan, because shader translation is broken.
So you need to use a dirty hack to not delete all your shaders.
Not to mention it breaks many games via MoltenVK because of changes to the shared GPU code.

Merging Metal seemed like a great idea, because of the few games it does support.
But I don't think it's worth it. Many of the games it breaks via MoltenVK *don't work via Metal*. 
Which effectively makes current Ryubing worse for Mac users than Ryujinx 1.1.1403.

I think what I'm gonna do is revert Metal, and reopen it as a PR. That way, you can still take advantage of the Metal backend as is, but without making other games worse with no solution.

For what it's worth, the shader translation part could at least be "fixed" by always applying a 30ms delay for shader translation to Metal.
That being said, that solution sucks ass.
The MoltenVK regressions are even worse.

I hope this is not a let down to the Mac users. I hope you realize I'm reverting this because you're actively getting a worse experience with it in the emulator.

@github-actions github-actions bot added gpu Affects GPU emulation gui Affects the Avalonia UI or translations. infra Updates to dependencies graphics-backend:metal Affects the Metal Graphics backend labels Feb 22, 2025
@GreemDev GreemDev marked this pull request as ready for review February 23, 2025 03:26
@GreemDev GreemDev merged commit fe1617f into master Feb 23, 2025
10 checks passed
GreemDev added a commit that referenced this pull request Feb 23, 2025
@GreemDev GreemDev deleted the revert/new-metal branch February 24, 2025 00:06
@GreemDev GreemDev mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Affects GPU emulation graphics-backend:metal Affects the Metal Graphics backend gui Affects the Avalonia UI or translations. infra Updates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant