Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: updated to include process-dependency-links option #131

Merged
merged 1 commit into from
May 2, 2018

Conversation

adrianherrera
Copy link
Member

We need to update the docs to include this process-dependency-links option.

I was just trying it out, and noticed that:

DEPRECATION: Dependency Links processing has been deprecated and will be removed in a future release.

We can achieve the same thing with the following requirements.txt file and removing install_requires from setup.py:

# S2E engine requirements
docutils
pygments

# s2e-env requirements
enum34
jinja2
pefile
psutil
git+https://github.com/s2e/pyelftools.git#egg=pyelftools==0.24s2e
python-magic
pyyaml
requests
sh
termcolor
pytrie

The downside of this is that it adds an extra step: a pip install -r requirements.txt before the main pip install . However, I think I prefer this method, regardless of the extra step, mainly because of the deprecation notice.

Thoughts?

@vitalych
Copy link
Member

I've seen this alternative and decided to stick with the deprecated option, because it's simple. It has been deprecated for a very long time now but hasn't been removed yet because they still didn't implement a proper alternative.

pypa/pip#4187

@adrianherrera
Copy link
Member Author

Ok, sounds reasonable to me :)

@adrianherrera adrianherrera merged commit b02329c into master May 2, 2018
@adrianherrera adrianherrera deleted the improvement/updated-readme branch May 2, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants