Restrict frameworks in paket.dependencies #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm up for doing this - it reduces a lot of complexity - but I've seen strange behaviour with Paket in the past with restrictions with regards to things like updating project references and the like. Just be aware - this should be tested out fully before merging :-) |
theimowski
commented
Oct 19, 2018
| source https://api.nuget.org/v3/index.json | ||
| storage: none |
There was a problem hiding this comment.
question to @matthid : can fake 5 dependencies be also restricted to a certain framework? e.g. framework: netstandard2.0 ?
There was a problem hiding this comment.
yes, in fact when using "paket-inline dependencies" framework: netstandard2.0 will be added by default:
|
Yep will need to test that thoroughly, however CI shows it builds for various options - so it should be all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.