update dependencies (nuget and npm) #199
Conversation
|
FontAwesome was removed from Fulma and added to its own package: Fulma/Fulma#166 (comment) For now I was lazy and locked Fulma to the old version. |
|
Locally green.
good night 💤💤💤 please note that I haven't done any other manual tests. |
|
Thanks for this! Can we add FontAwesome explicitly as well please? See #198 |
|
I have no clue how FA works. Can you tell me what to replace the old Icon.faIcon [ ]
[ Fa.icon Fa.I.Github; Fa.fw ]with? |
|
@isaacabraham Do you know what the new syntax is? Never used FA. |
|
@0x53A It's the same syntax as before, but in new Elmish you need to add the Fable.FontAwesome.Free package as well (and open |
|
@isaacabraham I tried it, but the new package seems to have completely different content.
|
|
You can check out the migration guide and new documentation: |
| [ ] | ||
| [ Fa.icon Fa.I.BellO ] ] | ||
| [ Fa.i [ Fa.Solid.Bell ] [] ] ] |
There was a problem hiding this comment.
BellO replacement is Fa.Regular.Bell
You can see the list of all the icon name change between version 4 and 5 here
| [ Icon.faIcon [ ] | ||
| [ Fa.icon Fa.I.Github; Fa.fw ] | ||
| [ Icon.icon [ ] | ||
| [ Fa.i [Fa.Brand.Github] [] ] |
There was a problem hiding this comment.
What does Fa.fw do, and what is the replacement?
There was a problem hiding this comment.
Fa.fw stand for fiwed-width
The replacement is Fa.FixedWidth
| [ Icon.faIcon [ ] | ||
| [ Fa.icon Fa.I.Github; Fa.fw ] | ||
| [ Icon.icon [ ] | ||
| [ Fa.i [Fa.Brand.Github] [] ] |
There was a problem hiding this comment.
What does Fa.fw do, and what is the replacement?
There was a problem hiding this comment.
Fa.fw stand for fiwed-width
The replacement is Fa.FixedWidth
| card Fa.I.IdCardO "Tempor orci dapibus ultrices in." "Ut venenatis tellus in metus vulputate. Amet consectetur adipiscing elit pellentesque. Sed arcu non odio euismod lacinia at quis risus. Faucibus turpis in eu mi bibendum neque egestas cmonsu songue. Phasellus vestibulum lorem sed risus." | ||
| card Fa.I.Rocket "Leo integer malesuada nunc vel risus." "Imperdiet dui accumsan sit amet nulla facilisi morbi. Fusce ut placerat orci nulla pellentesque dignissim enim. Libero id faucibus nisl tincidunt eget nullam. Commodo viverra maecenas accumsan lacus vel facilisis." ] | ||
| [ card Fa.Solid.Paw "Tristique senectus et netus et." "Purus semper eget duis at tellus at urna condimentum mattis. Non blandit massa enim nec. Integer enim neque volutpat ac tincidunt vitae semper quis. Accumsan tortor posuere ac ut consequat semper viverra nam." | ||
| card Fa.Solid.IdCard "Tempor orci dapibus ultrices in." "Ut venenatis tellus in metus vulputate. Amet consectetur adipiscing elit pellentesque. Sed arcu non odio euismod lacinia at quis risus. Faucibus turpis in eu mi bibendum neque egestas cmonsu songue. Phasellus vestibulum lorem sed risus." |
There was a problem hiding this comment.
IdCardO replacement is Fa.Regular.IdCard
You can see the list of all the icon name change between version 4 and 5 here
|
Awesome, thanks! |
I haven't run any manual tests, that's what CI is for