Be explicit that the returned object should be JSON #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got a bug in a private repo that took me forever to debug down though Thoth not wanting to run the extra encoders/decoders given to the `ThothSerializer`. The error I got was: ```txt 09:24:47 [Error] () Connection id ""0HLMNEG9T1D5V"", Request id ""0HLMNEG9T1D5V:00000001"": An unhandled exception was thrown by the application. System.AggregateException: One or more errors occurred. (Could not determine JSON object type for type Shared.Model+Msg+HomeMsg.) ---> System.ArgumentException: Could not determine JSON object type for type Shared.Model+Msg+HomeMsg. at Newtonsoft.Json.Linq.JValue.GetValueType(Nullable`1 current, Object value) at Thoth.Json.Net.Encode.autoEncoder@454-14.Invoke(Object v) at Thoth.Json.Giraffe.ThothSerializer.Giraffe-Serialization-Json-IJsonSerializer-SerializeToBytes[T](T o) at Giraffe.ResponseWriters.HttpContext.WriteJsonAsync[T](HttpContext this, T dataObj) in C:\projects\giraffe\src\Giraffe\ResponseWriters.fs:line 137 at Server.webApp@72-10.Invoke(FSharpOption`1 _arg2) in /Users/dbrattli/Developer/GitHub/xyz/src/Server/Server.fs:line 74 at FSharp.Control.Tasks.TaskBuilder.StepStateMachine`1.nextAwaitable() in C:\Users\humbo\source\repos\TaskBuilder.fs\TaskBuilder.fs:line 38 ``` The fix was to be explicit and use the `json` function e.g: ```fs return! Successful.ok (json msg) next ctx ``` instead of the current: ```fs return! Successful.OK msg next ctx ```` I propose this fix so that other developers that start off with the SAFE template will not get the same error when they extend their app with more complex types that eventually will make the handler fail with the bug above. The Saturn template btw already uses the `json` function for returning the object, so this fix should make the Giraffe and Saturn templates equivalent with regards to JSON handling.
|
/cc @isaacabraham is that the same change you made a while ago for Saturn? |
|
I guess it's OK to simplify this to: return! json counter next ctxShould I update the PR? |
|
@theimowski yes that sounds familiar - we should use |
|
Thanks! released in 1.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a bug in a private repo that took me forever to debug down through Thoth not wanting to run the extra encoders/decoders given to the
ThothSerializer. The error I got was:The fix was to be explicit and use the
jsonfunction e.g:instead of the current:
I propose this fix so that other developers that start off with the SAFE template will not get the same error when they extend their app with more complex types that eventually will make the handler fail with the bug above. The Saturn template btw already uses the
jsonfunction for returning the object, so this fix should make the Giraffe and Saturn templates equivalent with regards to JSON handling.