Fix Databricks provider version #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6240681607 (with refid (in response to this comment from @tanya-borisova) |
martinpeck
approved these changes
Sep 19, 2023
jjgriff93
approved these changes
Sep 20, 2023
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6247966214 (with refid (in response to this comment from @jjgriff93) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6248597981 (with refid (in response to this comment from @jjgriff93) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being addressed
Recent pull request #326 contains a bug: creation of databricks_metastore_assignment would sometimes error out with a message like "Storage credential XXX doesn't exist", and creation of metastore_data_access would also error out with a message like "No metastore assigned to the current workspace".
This has been fixed by upgrading the version of the provider to a newer one, and moving to account-level provider for these resources.
For more information, see databricks/terraform-provider-databricks#2182
Additional change I have made is now catalog name and schema name for Unity Catalog are passed in as Spark secrets, as opposed to pipeline inputs.