-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure only imaging studies are processed from OMOP ES parquet files #212
Comments
@stefpiatek this is public/PROCEDURE_OCCURRENCE.parquet {"procedure_occurrence_id":1,"person_id":1,"procedure_concept_id":4200610,"procedure_date":"2021-07-01T00:00:00.000Z","procedure_datetime":1625127300000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
{"procedure_occurrence_id":2,"person_id":1,"procedure_concept_id":4058335,"procedure_date":"2021-07-01T00:00:00.000Z","procedure_datetime":1625140800000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
{"procedure_occurrence_id":3,"person_id":2,"procedure_concept_id":4327032,"procedure_date":"2020-05-01T00:00:00.000Z","procedure_datetime":1588339813000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
{"procedure_occurrence_id":4,"person_id":2,"procedure_concept_id":4163872,"procedure_date":"2020-05-23T00:00:00.000Z","procedure_datetime":1590240671000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
{"procedure_occurrence_id":5,"person_id":2,"procedure_concept_id":4163872,"procedure_date":"2020-05-23T00:00:00.000Z","procedure_datetime":1590240940000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
{"procedure_occurrence_id":6,"person_id":3,"procedure_concept_id":4327032,"procedure_date":"2015-05-01T00:00:00.000Z","procedure_datetime":1430487013000,"procedure_type_concept_id":32817,"procedure_end_date":null,"procedure_end_datetime":null,"modifier_concept_id":0,"quantity":null,"visit_occurrence_id":null,"procedure_source_value":null,"procedure_source_concept_id":0,"modifier_source_value":null}
Only one of the ids mentioned in the code is here, and one is duplicated (the whole row is). Is that intentional? Would it make sense to keep the test data in some human readable format (so we can track it on github too) and only convert to parquet at test time? Or alternatively keep both (this introduces chance of them not matching)? |
I'd be up for having a helper test function that takes a CSV/json/toml of input data and then splits it out into parquet files in the format that we expect. Had been an option earlier that wasn't used in #159 in the testing heading |
Definition of Done / Acceptance Criteria
When reading data from OMOP ES, only imaging procedures (accessino number is not None) are added to PIXL queues
Testing
No changes needed.
Current status
None
as only imaging results will have that field filled in the link fileThe text was updated successfully, but these errors were encountered: