Set up ruff and fix trivial rules
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XL into milanmlft/issue-108-ruff
Docstrings feel like overkill for these functions
stefpiatek
reviewed
Dec 4, 2023
Specifying the `config=ruff.toml` ignores subdirectory `ruff.toml` files
…XL into milanmlft/issue-108-ruff
stefpiatek
reviewed
Dec 4, 2023
| exclude: "tests|orthanc" | ||
| - id: ruff | ||
| args: | ||
| - --fix |
There was a problem hiding this comment.
do you need to specify the config here as well?
Comment on lines
+282
to
+285
| Methods | ||
| ------- | ||
| from_state_file(cls, filepath) | ||
| Return messages from a state file path |
There was a problem hiding this comment.
Not sure if I'd put in the time to define the methods of a class here, as you've also got the public methods so its a bit of duplication
Comment on lines
+17
to
+20
| This module provides: | ||
| - fetch_key_from_vault: fetch the hashing key from the Azure Key Vault instance | ||
| - generate_hash: generate a keyed hash digest using the Blake2b algorithm | ||
| - generate_salt: generate a random text string in hexadecimal to be used as a salt |
There was a problem hiding this comment.
Fine to keep in but also probably a duplication of what's documented at the function level and could get out of date
| @@ -20,14 +22,14 @@ | |||
|
|
|||
|
|
|||
| @router.get("/heart-beat", summary="Health Check") | |||
| async def heart_beat() -> str: | |||
| async def heart_beat() -> str: # noqa: D103 | |||
There was a problem hiding this comment.
why don't we just document these?
Comment on lines
+45
to
+49
| background_tasks = set() | ||
| async with PixlConsumer(QUEUE_NAME, token_bucket=state.token_bucket) as consumer: | ||
| asyncio.create_task(consumer.run(callback=process_message)) | ||
| task = asyncio.create_task(consumer.run(callback=process_message)) | ||
| background_tasks.add(task) | ||
| task.add_done_callback(background_tasks.discard) |
There was a problem hiding this comment.
oh this is interesting that you had to add that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff.tomlfiles to configureruffruffto the pre-commit configurationisortandflake8from pre-commitmypyandruffruffissuesruffissues that require deeper investigation are ignored for now, but have been turned into new issues: #151, #152, #153, #154, #155, #156, #157Closes UCLH-Foundry/the-rolling-skeleton#108