Manage storage size on orthanc-raw
#176
Conversation
These new variable names are consistent with what is set in `.env` and `test/.env.test`
|
Putting as draft for now as this needs more proper testing, but would be keen to get some feedback already! |
| @@ -37,6 +37,7 @@ ORTHANC_RAW_USERNAME=orthanc_raw_username | |||
| ORTHANC_RAW_PASSWORD=orthanc_raw_password | |||
| ORTHANC_RAW_AE_TITLE=ORTHANCRAW | |||
| ORTHANC_AUTOROUTE_RAW_TO_ANON=true | |||
| ORTHANC_RAW_MAXIMUM_STORAGE_SIZE=1 | |||
There was a problem hiding this comment.
Do we want this to be limited during testing?
There was a problem hiding this comment.
I think having a low value makes testing easier as we won't need a huge amount of images to see if it's actually working. Note that this is just the sample file though, the actual .env.test is ignored so can easily be adapted locally. The 1 (MB) is just a default value for now.
There was a problem hiding this comment.
Ah yeah I guess if this is used in end to end tests then that might be an issue was my thought, but maybe it's not used in e2e tests in CI?
| // Limit the maximum storage size | ||
| "MaximumPatientCount" : 0, // no limit | ||
| "MaximumStorageSize" : ${ORTHANC_RAW_MAXIMUM_STORAGE_SIZE}, // MB | ||
| "MaximumStorageMode" : "Recycle", |
There was a problem hiding this comment.
🎉 Yeah this seems like a good shout. Worth testing on a dev version on the GAE. Which also reminds me that we need to document how we create a shared instance on the GAE when we make them
I'll make a PR based on step 1 of https://github.com/UCLH-DHCT/emap/edit/main/docs/core.md
This reverts commit 0842f43.
| "MaximumPatientCount": 20000, | ||
| // Limit the maximum storage size | ||
| "MaximumPatientCount" : 0, // no limit | ||
| "MaximumStorageSize" : ${ORTHANC_RAW_MAXIMUM_STORAGE_SIZE}, // MB |
There was a problem hiding this comment.
Turns out this doesn't work and results in an error ERROR: Unable to parse Json file '/run/secrets/orthanc.json'; check syntax , with the orthanc-raw service not even starting.
Using
"MaximumStorageSize" : "${ORTHANC_RAW_MAXIMUM_STORAGE_SIZE}", // MBin turn leads to the MaximumStorageSize parameter being ignored, because of a Bad parameter type error, as it needs to be an integer...
I've tried a couple of different things but it seems it's not possible get an environment variable read in as an integer in orthanc.json 🙁
@stefpiatek, @t-young31 any ideas?
There was a problem hiding this comment.
😞
no good ones. could: (a) hardcode, (b) copy the config file into the image and sed from a build argument. I don't suppose it works if you remove the quotes?
There was a problem hiding this comment.
Yeah I would have thought having the env variable without the quotes would work, sad if it doesn't. Agreed on using sed to replace inline if not, perhaps wrapping the variable usage with something that will make that replacement unique
|
Closing this, in favour of #179 |
Set the
MaximumStorageSizevariable in the configuation fororthanc-rawto recycle studies when running out of storage space.I tested this locally by uploading some random Dicom images I found online and then inspecting the
orthanc-rawlogs, so this seems to work?Fixes UCLH-Foundry/the-rolling-skeleton#69, also closes #130 (I think?)
To do