Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send images to imaging queue if they have been exported #202

Merged
merged 21 commits into from
Jan 4, 2024
Merged

Don't send images to imaging queue if they have been exported #202

merged 21 commits into from
Jan 4, 2024

Conversation

stefpiatek
Copy link
Contributor

closes #160

  • postgres container now runs sqlaclhemy to create the required imaging tables
  • messages filtered out if they have been exported
  • Moved the config function into a seperate module to avoid a circular import

milanmlft
milanmlft approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few small suggestions

@stefpiatek stefpiatek requested a review from milanmlft January 4, 2024 09:43
@stefpiatek stefpiatek requested a review from ruaridhg January 4, 2024 12:20
milanmlft
milanmlft approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@milanmlft milanmlft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stefpiatek stefpiatek enabled auto-merge (squash) January 4, 2024 14:55
@stefpiatek stefpiatek merged commit 4cb94ac into main Jan 4, 2024
@stefpiatek stefpiatek deleted the rmg/vna_img_tracking branch January 4, 2024 14:55
@stefpiatek stefpiatek linked an issue Jan 15, 2024 that may be closed by this pull request
Image pseudonymisation stored in database #188
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanmlft milanmlft milanmlft approved these changes

@jeremyestein jeremyestein Awaiting requested review from jeremyestein

@ruaridhg ruaridhg Awaiting requested review from ruaridhg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image pseudonymisation stored in database Ensure VNA isn't queried for messages already sent to destination
3 participants
@stefpiatek @milanmlft @ruaridhg