-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for pseudonymisation #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruaridhg
force-pushed
the
rmg/img_pseudoanon
branch
from
January 11, 2024 15:22
303eeb5
to
90521eb
Compare
…age_pseudonymisation # Conflicts: # pixl_dcmd/src/pixl_dcmd/_database.py # pixl_dcmd/src/pixl_dcmd/main.py # pixl_dcmd/src/pixl_dcmd/tests/conftest.py # pixl_dcmd/src/pixl_dcmd/tests/test_datetime.py
ruaridhg
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will add in the env vars now
ruaridhg
added a commit
that referenced
this pull request
Jan 12, 2024
* Updated hash and added to db * Query PIXL db within pixl_dcmd to check dataset exported * Updated hash_value, started tests * Remove unused requirements * Split out deid and datetime helpers * Use env variables to connect to PIXL db * Update inputs for tag tests to run * Negative test for image already exported * Negative test for image already exported * Use == instead of is for PIXL query * Install core in CI * Check editable install uses dir * Rollback python version for core --------- Co-authored-by: ruaridhg <ruaridhg@users.noreply.github.com>
ruaridhg
added a commit
that referenced
this pull request
Jan 12, 2024
* Updated hash and added to db * Query PIXL db within pixl_dcmd to check dataset exported * Updated hash_value, started tests * dummy env vars for hasher and mock requests library * Add tests for pseudonymisation (#214) * Updated hash and added to db * Query PIXL db within pixl_dcmd to check dataset exported * Updated hash_value, started tests * Remove unused requirements * Split out deid and datetime helpers * Use env variables to connect to PIXL db * Update inputs for tag tests to run * Negative test for image already exported * Negative test for image already exported * Use == instead of is for PIXL query * Install core in CI * Check editable install uses dir * Rollback python version for core --------- Co-authored-by: ruaridhg <ruaridhg@users.noreply.github.com> * ENV vars set, skeleton mock requests * Mock requests added to conftest * Remove unnecessary comments * Update fixture to be more generic * Update workflow to install pixl_core first * Updated pydicom to 2.4.4 * Updated pydicom to 2.4.4 * Reading in testdata_file differently * Reading in testdata_file like originally * Workflow install pydicom-data * Add pydicom-data to requirements * Added PR suggestions * Moved tests back to org location * Revert dir errors * Fix system tests * Revert workflow * Try pip install pixl_core * import annotations to fix linting * -e workflow * install pixl_core in orthanc-anon Dockerfile --------- Co-authored-by: ruaridhg <ruaridhg@users.noreply.github.com> Co-authored-by: Stef Piatek <s.piatek@ucl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed
config
so that makes it easier and tests can be run from anywhereNext steps assuming you're happy with these
I think this will need a couple of things for it to work:
os.environ
,conftest.py
is a classic place to do this because its run before the test. Then the env variables exist during testing with dummy values so we don't throw errorsstatuscode
andcontent
fields