Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in placeholder substitution #217

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix error in placeholder substitution #217

merged 1 commit into from
Jan 12, 2024

Conversation

jeremyestein
Copy link
Contributor

@jeremyestein jeremyestein commented Jan 11, 2024 •
edited
Loading

I think this unbreaks things but I may have misunderstood what this code is supposed to do.

stefpiatek
stefpiatek approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing!

@milanmlft milanmlft merged commit e110e0a into main Jan 12, 2024
8 checks passed
@milanmlft milanmlft deleted the jeremy/fix-build branch January 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

@milanmlft milanmlft Awaiting requested review from milanmlft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyestein @stefpiatek @milanmlft